hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Inigo Goiri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4808) SchedulerNode can use a few more cosmetic changes
Date Mon, 14 Mar 2016 03:02:33 GMT

    [ https://issues.apache.org/jira/browse/YARN-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192693#comment-15192693
] 

Inigo Goiri commented on YARN-4808:
-----------------------------------

I'd say is slightly cleaner using just {{RMNode}} to hold utilization data and not having
to update
Not 100% sure we are updating everything but {{TestMiniYarnClusterNodeUtilization} from YARN-3980
should be checking that so we should be good.

> SchedulerNode can use a few more cosmetic changes
> -------------------------------------------------
>
>                 Key: YARN-4808
>                 URL: https://issues.apache.org/jira/browse/YARN-4808
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 2.8.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: yarn-4808-1.patch
>
>
> We have made some cosmetic changes to SchedulerNode recently. While working on YARN-4511,
realized we could improve it a little more:
> # Remove volatile variables - don't see the need for them being volatile
> # Some methods end up doing very similar things, so consolidating them
> # Renaming totalResource to capacity. YARN-4511 plans to add inflatedCapacity to include
the un-utilized resources, and having two totals can be a little confusing. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message