hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yufei Gu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long
Date Thu, 31 Mar 2016 05:32:25 GMT

    [ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219380#comment-15219380
] 

Yufei Gu commented on YARN-4807:
--------------------------------

Thanks [~kasha@cloudera.com] for review and very nice suggestions. 

Besides return type, there are even more inconsistencies among these {{waitForState}}, some
ones have a minimum waiting time(1000ms), some one don't. I appreciate if someone can explain
why we need a minimum waiting time. Another inconsistency is some wait function don't have
a timeout, they can wait for ever. And there are more, e.g. some functions use {{LOG.info}}
and others use {{System.out.println}} to print messages. 

It's better to discuss and make a decision to solve these inconsistencies. Or put them in
a follow up JIRA. 

> MockAM#waitForState sleep duration is too long
> ----------------------------------------------
>
>                 Key: YARN-4807
>                 URL: https://issues.apache.org/jira/browse/YARN-4807
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.8.0
>            Reporter: Karthik Kambatla
>            Assignee: Yufei Gu
>              Labels: newbie
>         Attachments: YARN-4807.001.patch, YARN-4807.002.patch, YARN-4807.003.patch, YARN-4807.004.patch,
YARN-4807.005.patch
>
>
> MockAM#waitForState sleep duration (500 ms) is too long. Also, there is significant duplication
with MockRM#waitForState.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message