hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long
Date Thu, 31 Mar 2016 00:07:25 GMT

    [ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219092#comment-15219092
] 

Karthik Kambatla commented on YARN-4807:
----------------------------------------

Quickly skimmed through the patch. Couple of comments:
# Some of the waitForState methods return boolean, while others return void but have asserts
in them. I would prefer them to be consistent. May be return a boolean is better so the tests
could log context-sensitive comments? If that ends up being a significant chunk of work, I
am fine with doing it in a follow up JIRA.
# Nit: For the loops where we are incrementing something and also checking condition on every
iteration, I prefer using {{for}} instead of {{while}}. If we choose to stick with {{while}},
can we please do {{loop++}} where we check. 

> MockAM#waitForState sleep duration is too long
> ----------------------------------------------
>
>                 Key: YARN-4807
>                 URL: https://issues.apache.org/jira/browse/YARN-4807
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.8.0
>            Reporter: Karthik Kambatla
>            Assignee: Yufei Gu
>              Labels: newbie
>         Attachments: YARN-4807.001.patch, YARN-4807.002.patch, YARN-4807.003.patch, YARN-4807.004.patch,
YARN-4807.005.patch
>
>
> MockAM#waitForState sleep duration (500 ms) is too long. Also, there is significant duplication
with MockRM#waitForState.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message