hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long
Date Tue, 29 Mar 2016 14:03:25 GMT

    [ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15216044#comment-15216044
] 

Daniel Templeton commented on YARN-4807:
----------------------------------------

Thanks, [~yufeigu]!  Looks really good.  To bring this full circle, I noticed that now you
have {{40*1000}} and {{10*1000}} each used twice in {{MockRM}}.  Might be worth making those
constants (again).  Also, it would be really super swell of you could add JavaDocs for the
{{MockRM}} and {{MockAM}} methods that you touched, especially since there are now implicit
timeouts that can be optionally overridden.

> MockAM#waitForState sleep duration is too long
> ----------------------------------------------
>
>                 Key: YARN-4807
>                 URL: https://issues.apache.org/jira/browse/YARN-4807
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.8.0
>            Reporter: Karthik Kambatla
>            Assignee: Yufei Gu
>              Labels: newbie
>         Attachments: YARN-4807.001.patch, YARN-4807.002.patch, YARN-4807.003.patch
>
>
> MockAM#waitForState sleep duration (500 ms) is too long. Also, there is significant duplication
with MockRM#waitForState.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message