hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3863) Support complex filters in TimelineReader
Date Thu, 10 Mar 2016 00:38:40 GMT

    [ https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188389#comment-15188389
] 

Sangjin Lee commented on YARN-3863:
-----------------------------------

The latest patch looks good. Just one remaining question that I'd like a quick answer on.
It seems that the null check of the {{TimelineEntityReader.getFilters()}} is not entirely
consistent. There are 23 invocations throughout the code (including this patch), and none
of them checks for null but for these 3:

{noformat}
ApplicationEntityReader.constructFilterListBasedOnFilters()
ApplicationEntityReader.parseEntity()
GenericEntityReader.parseEntity()
{noformat}

I suspect null should not happen. In that case, would it make sense to make it clear (in javadoc
or comments) that filters can never be null and skip the null check? Otherwise, we should
check for null everywhere. Thoughts?

> Support complex filters in TimelineReader
> -----------------------------------------
>
>                 Key: YARN-3863
>                 URL: https://issues.apache.org/jira/browse/YARN-3863
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-3863-YARN-2928.v2.01.patch, YARN-3863-YARN-2928.v2.02.patch,
YARN-3863-YARN-2928.v2.03.patch, YARN-3863-YARN-2928.v2.04.patch, YARN-3863-feature-YARN-2928.wip.003.patch,
YARN-3863-feature-YARN-2928.wip.01.patch, YARN-3863-feature-YARN-2928.wip.02.patch, YARN-3863-feature-YARN-2928.wip.04.patch,
YARN-3863-feature-YARN-2928.wip.05.patch
>
>
> Currently filters in timeline reader will return an entity only if all the filter conditions
hold true i.e. only AND operation is supported. We can support OR operation for the filters
as well. Additionally as primary backend implementation is HBase, we can design our filters
in a manner, where they closely resemble HBase Filters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message