Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8594018702 for ; Mon, 1 Feb 2016 16:01:04 +0000 (UTC) Received: (qmail 25147 invoked by uid 500); 1 Feb 2016 16:00:42 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 25110 invoked by uid 500); 1 Feb 2016 16:00:42 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 25034 invoked by uid 99); 1 Feb 2016 16:00:42 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Feb 2016 16:00:42 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D9F0D2C1F58 for ; Mon, 1 Feb 2016 16:00:41 +0000 (UTC) Date: Mon, 1 Feb 2016 16:00:41 +0000 (UTC) From: "Hadoop QA (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3367) Replace starting a separate thread for post entity with event loop in TimelineClient MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3367?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15126= 446#comment-15126446 ]=20 Hadoop QA commented on YARN-3367: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {= color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m= 0s {color} | {color:green} The patch does not contain any @author tags. {c= olor} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s {color} | {color:green} The patch appears to include 3 new or modifi= ed test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 18s = {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 9m 34s {color} | {color:green} YARN-2928 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m= 26s {color} | {color:green} YARN-2928 passed with JDK v1.8.0_66 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m= 54s {color} | {color:green} YARN-2928 passed with JDK v1.7.0_91 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 1m 20s {color} | {color:green} YARN-2928 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3m= 31s {color} | {color:green} YARN-2928 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}= 1m 47s {color} | {color:green} YARN-2928 passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6= m 11s {color} | {color:green} YARN-2928 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m= 31s {color} | {color:green} YARN-2928 passed with JDK v1.8.0_66 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m= 3s {color} | {color:green} YARN-2928 passed with JDK v1.7.0_91 {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 11s = {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 2m 49s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m= 58s {color} | {color:green} the patch passed with JDK v1.8.0_66 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 5= 8s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m= 57s {color} | {color:green} the patch passed with JDK v1.7.0_91 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m 5= 7s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 19= s {color} | {color:red} root: patch generated 13 new + 711 unchanged - 11 f= ixed =3D 724 total (was 722) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3m= 33s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}= 1m 45s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s= {color} | {color:red} The patch has 3 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s = {color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7= m 53s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m= 31s {color} | {color:green} the patch passed with JDK v1.8.0_66 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m= 4s {color} | {color:green} the patch passed with JDK v1.7.0_91 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 25= s {color} | {color:green} hadoop-yarn-api in the patch passed with JDK v1.8= .0_66. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 2m 8s {colo= r} | {color:red} hadoop-yarn-common in the patch failed with JDK v1.8.0_66.= {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 48s {col= or} | {color:red} hadoop-yarn-server-nodemanager in the patch failed with J= DK v1.8.0_66. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 64m 33s {co= lor} | {color:red} hadoop-yarn-client in the patch failed with JDK v1.8.0_6= 6. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 5m 30s {col= or} | {color:red} hadoop-yarn-applications-distributedshell in the patch fa= iled with JDK v1.8.0_66. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m 2= s {color} | {color:green} hadoop-mapreduce-client-app in the patch passed w= ith JDK v1.8.0_66. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 79m 44s {co= lor} | {color:red} hadoop-mapreduce-client-jobclient in the patch failed wi= th JDK v1.8.0_66. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 37= s {color} | {color:green} hadoop-yarn-api in the patch passed with JDK v1.7= .0_91. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 48= s {color} | {color:green} hadoop-yarn-common in the patch passed with JDK v= 1.7.0_91. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 9m 37s {col= or} | {color:red} hadoop-yarn-server-nodemanager in the patch failed with J= DK v1.7.0_91. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 64m 53s {co= lor} | {color:red} hadoop-yarn-client in the patch failed with JDK v1.7.0_9= 1. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 11s {col= or} | {color:red} hadoop-yarn-applications-distributedshell in the patch fa= iled with JDK v1.7.0_91. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m 9= s {color} | {color:green} hadoop-mapreduce-client-app in the patch passed w= ith JDK v1.7.0_91. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 79m 41s {co= lor} | {color:red} hadoop-mapreduce-client-jobclient in the patch failed wi= th JDK v1.7.0_91. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 30= s {color} | {color:red} Patch generated 11 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 433m 51s {co= lor} | {color:black} {color} | \\ \\ || Reason || Tests || | JDK v1.8.0_66 Failed junit tests | hadoop.yarn.client.api.impl.TestTimeli= neClientV2Impl | | | hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourc= eLocalizationService | | | hadoop.yarn.client.TestGetGroups | | | hadoop.mapred.TestNetworkedJob | | JDK v1.8.0_66 Timed out junit tests | org.apache.hadoop.yarn.client.cli.T= estYarnCLI | | | org.apache.hadoop.yarn.client.api.impl.TestAMRMClient | | | org.apache.hadoop.yarn.client.api.impl.TestYarnClient | | | org.apache.hadoop.yarn.client.api.impl.TestNMClient | | | org.apache.hadoop.yarn.applications.distributedshell.TestDistributedS= hell | | | org.apache.hadoop.mapred.TestMRTimelineEventHandling | | | org.apache.hadoop.mapreduce.v2.TestMRJobs | | JDK v1.7.0_91 Failed junit tests | hadoop.yarn.client.TestGetGroups | | | hadoop.mapred.TestNetworkedJob | | JDK v1.7.0_91 Timed out junit tests | org.apache.hadoop.yarn.client.cli.T= estYarnCLI | | | org.apache.hadoop.yarn.client.api.impl.TestAMRMClient | | | org.apache.hadoop.yarn.client.api.impl.TestYarnClient | | | org.apache.hadoop.yarn.client.api.impl.TestNMClient | | | org.apache.hadoop.yarn.applications.distributedshell.TestDistributedS= hell | | | org.apache.hadoop.mapreduce.v2.TestUberAM | | | org.apache.hadoop.mapred.TestMRTimelineEventHandling | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:0ca8df7 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1278541= 0/YARN-3367-YARN-2928.v1.007.patch | | JIRA Issue | YARN-3367 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsit= e unit findbugs checkstyle xml | | uname | Linux f9902dc7119e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT We= d Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provide= d.sh | | git revision | YARN-2928 / e2e5a9a | | Default Java | 1.7.0_91 | | Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/ja= va-7-openjdk-amd64:1.7.0_91 | | findbugs | v3.0.0 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/10454/art= ifact/patchprocess/diff-checkstyle-root.txt | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/10454/art= ifact/patchprocess/whitespace-tabs.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/10454/artifact/= patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-= jdk1.8.0_66.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/10454/artifact/= patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_= hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/10454/artifact/= patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-= jdk1.8.0_66.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/10454/artifact/= patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applica= tions_hadoop-yarn-applications-distributedshell-jdk1.8.0_66.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/10454/artifact/= patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_ha= doop-mapreduce-client-jobclient-jdk1.8.0_66.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/10454/artifact/= patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_= hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/10454/artifact/= patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-= jdk1.7.0_91.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/10454/artifact/= patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applica= tions_hadoop-yarn-applications-distributedshell-jdk1.7.0_91.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/10454/artifact/= patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_ha= doop-mapreduce-client-jobclient-jdk1.7.0_91.txt | | unit test logs | https://builds.apache.org/job/PreCommit-YARN-Build/1045= 4/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-y= arn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Bui= ld/10454/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_h= adoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt https://bu= ilds.apache.org/job/PreCommit-YARN-Build/10454/artifact/patchprocess/patch-= unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt htt= ps://builds.apache.org/job/PreCommit-YARN-Build/10454/artifact/patchprocess= /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop= -yarn-applications-distributedshell-jdk1.8.0_66.txt https://builds.apache.o= rg/job/PreCommit-YARN-Build/10454/artifact/patchprocess/patch-unit-hadoop-m= apreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-= jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10454/ar= tifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-= client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/1= 0454/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoo= p-yarn-applications_hadoop-yarn-applications-distributedshell-jdk1.7.0_91.t= xt https://builds.apache.org/job/PreCommit-YARN-Build/10454/artifact/patchp= rocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-m= apreduce-client-jobclient-jdk1.7.0_91.txt | | JDK v1.7.0_91 Test Results | https://builds.apache.org/job/PreCommit-YAR= N-Build/10454/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-YARN-Build/10454/art= ifact/patchprocess/patch-asflicense-problems.txt | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-ya= rn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn= /hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-proje= ct/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-= project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-ma= preduce-client/hadoop-mapreduce-client-app hadoop-yarn-project/hadoop-yar= n/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell U: . = | | Max memory used | 90MB | | Powered by | Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/10454= /console | This message was automatically generated. > Replace starting a separate thread for post entity with event loop in Tim= elineClient > -------------------------------------------------------------------------= ----------- > > Key: YARN-3367 > URL: https://issues.apache.org/jira/browse/YARN-3367 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Affects Versions: YARN-2928 > Reporter: Junping Du > Assignee: Naganarasimha G R > Labels: yarn-2928-1st-milestone > Attachments: YARN-3367-YARN-2928.v1.005.patch, YARN-3367-YARN-292= 8.v1.006.patch, YARN-3367-YARN-2928.v1.007.patch, YARN-3367-feature-YARN-29= 28.003.patch, YARN-3367-feature-YARN-2928.v1.002.patch, YARN-3367-feature-Y= ARN-2928.v1.004.patch, YARN-3367.YARN-2928.001.patch, sjlee-suggestion.patc= h > > > Since YARN-3039, we add loop in TimelineClient to wait for collectorServi= ceAddress ready before posting any entity. In consumer of TimelineClient (= like AM), we are starting a new thread for each call to get rid of potentia= l deadlock in main thread. This way has at least 3 major defects: > 1. The consumer need some additional code to wrap a thread before calling= putEntities() in TimelineClient. > 2. It cost many thread resources which is unnecessary. > 3. The sequence of events could be out of order because each posting oper= ation thread get out of waiting loop randomly. > We should have something like event loop in TimelineClient side, putEntit= ies() only put related entities into a queue of entities and a separated th= read handle to deliver entities in queue to collector via REST call. -- This message was sent by Atlassian JIRA (v6.3.4#6332)