hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4696) EntityGroupFSTimelineStore to work in the absence of an RM
Date Wed, 17 Feb 2016 23:33:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151422#comment-15151422
] 

Li Lu commented on YARN-4696:
-----------------------------

Thanks [~stevel@apache.org]! This new override based solution works better IMHO. Some minor
questions:

- Since we have already switched to the override based approach, do we still need to introduce
the new config key? I guess not, but just to make sure this because we're still changing yarn-default?

- I noticed the following lines of comments:
{code}
* If they return null, then {@link #getAppState(ApplicationId)} will
* also need to be reworked.
{code}
This coupling appears to be a little bit error-pruning, since people may easily ignore this
comment. Do you think it worth the effort to encapsulate getAppState into an interface inside
the storage? We may also want to move the yarnClient there so that the semantic is completely
isolated from the actual implementation. For UTs we can easily build a trivial app state fetcher
that does nothing. Not sure if this is an over-design though...

> EntityGroupFSTimelineStore to work in the absence of an RM
> ----------------------------------------------------------
>
>                 Key: YARN-4696
>                 URL: https://issues.apache.org/jira/browse/YARN-4696
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: YARN-4696-001.patch, YARN-4696-002.patch
>
>
> {{EntityGroupFSTimelineStore}} now depends on an RM being up and running; the configuration
pointing to it. This is a new change, and impacts testing where you have historically been
able to test without an RM running.
> The sole purpose of the probe is to automatically determine if an app is running; it
falls back to "unknown" if not. If the RM connection was optional, the "unknown" codepath
could be called directly, relying on age of file as a metric of completion
> Options
> # add a flag to disable RM connect
> # skip automatically if RM not defined/set to 0.0.0.0
> # disable retries on yarn client IPC; if it fails, tag app as unknown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message