hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4671) There is no need to acquire CS lock when completing a container
Date Mon, 22 Feb 2016 13:42:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156932#comment-15156932
] 

Jian He commented on YARN-4671:
-------------------------------

+1, lgtm

> There is no need to acquire CS lock when completing a container
> ---------------------------------------------------------------
>
>                 Key: YARN-4671
>                 URL: https://issues.apache.org/jira/browse/YARN-4671
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: MENG DING
>            Assignee: MENG DING
>         Attachments: YARN-4671.1.patch
>
>
> In YARN-4519, we discovered that there is no need to acquire CS lock in CS#completedContainerInternal,
because:
> * Access to critical section are already guarded by queue lock.
> * It is not essential to guard {{schedulerHealth}} with cs lock in completedContainerInternal.
All maps in schedulerHealth are concurrent maps. Even if schedulerHealth is not consistent
at the moment, it will be eventually consistent.
> With this fix, we can truly claim that CS#allocate doesn't require CS lock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message