hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi Ozawa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4648) Move preemption related tests from TestFairScheduler to TestFairSchedulerPreemption
Date Mon, 15 Feb 2016 05:39:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146932#comment-15146932
] 

Tsuyoshi Ozawa commented on YARN-4648:
--------------------------------------

[~lewuathe] thank you for your contribution. I looked over your patch. I have some comments,
so could you address them? 

{code}
  private void startResourceManagerWithoutThreshold() {
{code}
Why not reusing startResourceManager(threshold) with the threshold larger than 1.0f?

{code}
+import org.apache.hadoop.yarn.api.records.*;
{code}

Please don't use * import.

> Move preemption related tests from TestFairScheduler to TestFairSchedulerPreemption
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-4648
>                 URL: https://issues.apache.org/jira/browse/YARN-4648
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.8.0
>            Reporter: Karthik Kambatla
>            Assignee: Kai Sasaki
>              Labels: newbie++
>         Attachments: YARN-4648.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message