hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4634) Scheduler UI/Metrics need to consider cases like non-queue label mappings
Date Fri, 19 Feb 2016 13:27:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154206#comment-15154206
] 

Sunil G commented on YARN-4634:
-------------------------------

Hi [~leftnoteasy]
Thank you for the clarification. Pls correct me if I am wrong, I think it is also handled.

{{RMNodeLabelsManager#reinitializeQueueLabels}} is invoked with queueToLabels as arguement.
Here queueToLabels is actually {{CS#getQueueToLabels()}}. And this *getQueueToLabels()* will
be collecting the labels configured per queue from {{queue.getAccessibleNodeLabels()}}, and
this can be ANY or "*" in default case.

Now in {{reinitializeQueueLabels}}, I am setting {{setLabelToQueueMappingAvailable()}} to
true after the check with *ANY*. 
{code}
        Set<String> labels = entry.getValue();
        if (labels.contains(ANY)) {
          continue;
        }

        this.setLabelToQueueMappingAvailable(true);
{code}

So isLabelToQueueMappingAvailable() will cover the default cause of ANY which will coming
from {{getAccessibleNodeLabels}} from a queue. Pls help to share your thoughts on this. If
this is not the case which you were mentionining, could you pls help to point the same.

> Scheduler UI/Metrics need to consider cases like non-queue label mappings
> -------------------------------------------------------------------------
>
>                 Key: YARN-4634
>                 URL: https://issues.apache.org/jira/browse/YARN-4634
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.7.1
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-4634.patch
>
>
> Currently when label-queue mappings are not available, there are few assumptions taken
in UI and in metrics.
> In above case where labels are enabled and available in cluster but without any queue
mappings, UI displays queues under labels. This is not correct.
> Currently  labels enabled check and availability of labels are considered to render scheduler
UI. Henceforth we also need to check whether 
> - queue-mappings are available
> - nodes are mapped with labels with proper exclusivity flags on
> This ticket also will try to see the default configurations in queue when labels are
not mapped. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message