hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4517) [YARN-3368] Add nodes page
Date Sun, 21 Feb 2016 11:16:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155987#comment-15155987
] 

Varun Saxena commented on YARN-4517:
------------------------------------

[~leftnoteasy], [~jianhe], kindly review.
I have attached the screenshots too.

*The patch does the following.*
# Implements RM nodes page.
# Implements all NM pages, including node info page, apps page, single app page listing containers
for the app, containers page, single container page and container logs page. Give exactly
the same information as current web UI.
# Added natural sort for sorting app ids'.
# Global error handler to display 404 or some other error page(a basic text page, can be improved
if required later). Custom error pages like 404 can be added later. We can also make other
decisions based on error code as well(say, retry).
# Make cluster overview page as the home page i.e. we will no longer see an empty page with
top level menu bar on accessing {{http://localhost:4200}}. Should cluster overview instead
of queues be the leftmost tab ?
# Added donut graphs on Node Information page to display node resource usage. Other graphs
we can discuss and add later.
# Also added handling for the case where server returns no apps or containers. For this, I
am basically creating a dummy response from serializer. This might not be the best way to
handle it in Ember but I could not come up with much else until now.
# Make the tabs in top level menu active based on the tab being accessed.

*Open issues/points :*
# The JSON coming from NM for containers and container endpoint is incorrect. Because of this
only one log file is seen in the logs link of containers page in UI. This is because jQuery's
JSON parser, only picks up the last log file value. I have raised YARN-4709 to track this.
After that goes, code here will have to be changed here to display links to all 3 log files.
# The heading(which shows NM IP and port i.e. NM ID) on top of left hand side menu overflows
out of the panel for certain browser dimensions. If I insert a space between host and port,
it works fine, but space doesnt look good. Will have to explore a bit on how to handle it.
# We can probably add some graphs on the app page to capture container lifecycle by returning
timestamps of events like localization, launching, etc.. This can be done later.
# Haven't added any tests so far. Will have to explore how to add them. Will probably do after
first round of review.

The ASF license warnings are due to missing of apache header. I had added it for new files
I added. Should I add it for other files too ?

> [YARN-3368] Add nodes page
> --------------------------
>
>                 Key: YARN-4517
>                 URL: https://issues.apache.org/jira/browse/YARN-4517
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Wangda Tan
>            Assignee: Varun Saxena
>              Labels: webui
>         Attachments: (21-Feb-2016)yarn-ui-screenshots.zip, YARN-4517-YARN-3368.01.patch
>
>
> We need nodes page added to next generation web UI, similar to existing RM/nodes page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message