hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4420) Add REST API for List Reservations
Date Fri, 05 Feb 2016 23:23:39 GMT

    [ https://issues.apache.org/jira/browse/YARN-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135245#comment-15135245
] 

Subru Krishnan commented on YARN-4420:
--------------------------------------

Thanks [~seanpo03] for submitting the patch. I took a look at it & please find my comments
below:

  * In *RMWebServices::listReservation*, use _ReservationListRequest::newInstance_ instead
of individual field setters
  * Can we inspect the exception to distinguish between bad request and internal error in
*RMWebServices::listReservation*
  * There is copy-paste typo in the log statement in *RMWebServices::listReservation*, change
_Update_ to _List_
  * Nit: in *TestRMWebServicesReservation*, clock can be final
  * Can we assert for other attributes and not just the _ReservationId_ by recasting _testRetrieveRDL_
as a helper method in *TestRMWebServicesReservation*
  * Rename _testPositiveIncludeResourceAllocations/testNegativeIncludeResourceAllocations_
to be more readable

To fix the asf license error, add a RAT exclusion for submit-reservation-custom json in resource
manager pom file. An easier option would be to edit the existing input to accommodate the
new scenarios you have added. This will help clean up testSubmissionReservationHelper also.

> Add REST API for List Reservations
> ----------------------------------
>
>                 Key: YARN-4420
>                 URL: https://issues.apache.org/jira/browse/YARN-4420
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler, fairscheduler, resourcemanager
>            Reporter: Sean Po
>            Assignee: Sean Po
>            Priority: Minor
>         Attachments: YARN-4420.v1.patch, YARN-4420.v2.patch, YARN-4420.v3.patch
>
>
> This JIRA tracks changes to the REST APIs of the reservation system and enables querying
the reservation on which reservations exists by "time-range, and reservation-id". 
> This task has a dependency on YARN-4340.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message