hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4138) Roll back container resource allocation after resource increase token expires
Date Wed, 03 Feb 2016 10:31:39 GMT

    [ https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130206#comment-15130206
] 

Jian He commented on YARN-4138:
-------------------------------

Patch looks good to me overall,
one question for this test case:
After step 6, rmContainer.getLastConfirmedResource() will return 3G, when the expire event
gets triggered, won't it reset it back to 3G?
{code}
    /**
     * 1. Allocate 1 container: containerId2 (1G)
     * 2. Increase resource of containerId2: 1G -> 3G
     * 3. AM acquires the token
     * 4. Increase resource of containerId2 again: 3G -> 6G
     * 5. AM acquires the token
     * 6. AM uses the 1st token to increase the container in NM to 3G
     * 7. AM does NOT use the second token
     * 8. Verify containerId2 eventually uses 1G after token expires
{code}
- I think RMContainerImpl will not receive EXPIRE event at RUNNING state after this patch
? if so, we can remove this.
{code}
.addTransition(RMContainerState.RUNNING, RMContainerState.RUNNING,
        RMContainerEventType.EXPIRE)
{code}

> Roll back container resource allocation after resource increase token expires
> -----------------------------------------------------------------------------
>
>                 Key: YARN-4138
>                 URL: https://issues.apache.org/jira/browse/YARN-4138
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, nodemanager, resourcemanager
>            Reporter: MENG DING
>            Assignee: MENG DING
>         Attachments: YARN-4138-YARN-1197.1.patch, YARN-4138-YARN-1197.2.patch, YARN-4138.3.patch,
YARN-4138.4.patch
>
>
> In YARN-1651, after container resource increase token expires, the running container
is killed.
> This ticket will change the behavior such that when a container resource increase token
expires, the resource allocation of the container will be reverted back to the value before
the increase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message