hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3863) Support complex filters in TimelineReader
Date Fri, 26 Feb 2016 22:02:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169930#comment-15169930
] 

Varun Saxena commented on YARN-3863:
------------------------------------

Coming to review comments,
bq. I know this is happening deep inside the method, but it seems like a bit of an anti-pattern
that we have to reference whether something is an application v. entity. 
I think we can simply move all these methods to ApplicationEntityReader as well with only
application specific code.

bq. This is more of a question. Is a list of multiple equality filters the same as the multi-val
equality filter? If not, how are they different?
Yes, they are same. Just that, we will have to peek for the same key again and again, while
matching.

bq. (TimelineMultiValueEqualityFilter.java)
The name is bit confusing (see above)
Maybe we can change TimelineEqualityFilter to TimelineKeyValueFilter and this one to TimelineKeyValuesFilter
?

> Support complex filters in TimelineReader
> -----------------------------------------
>
>                 Key: YARN-3863
>                 URL: https://issues.apache.org/jira/browse/YARN-3863
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-3863-YARN-2928.v2.01.patch, YARN-3863-YARN-2928.v2.02.patch,
YARN-3863-feature-YARN-2928.wip.003.patch, YARN-3863-feature-YARN-2928.wip.01.patch, YARN-3863-feature-YARN-2928.wip.02.patch,
YARN-3863-feature-YARN-2928.wip.04.patch, YARN-3863-feature-YARN-2928.wip.05.patch
>
>
> Currently filters in timeline reader will return an entity only if all the filter conditions
hold true i.e. only AND operation is supported. We can support OR operation for the filters
as well. Additionally as primary backend implementation is HBase, we can design our filters
in a manner, where they closely resemble HBase Filters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message