hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2575) Consider creating separate ACLs for Reservation create/update/delete/list ops
Date Wed, 10 Feb 2016 07:53:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140473#comment-15140473
] 

Arun Suresh commented on YARN-2575:
-----------------------------------

Thank you for working on this [~seanpo03].. I took a the latest patch. It looks good overall
and I like the coverage in the testcase. Few very Minor nit :

# The {{ReservationsACLsManager}} manager has a no arg constructor which you've marked as
*VisibileForTesting* but I dont see it being used. You can probably remove it
# Typo in testcase method name. should be * createFairSchedulerConfiguration*
# The Javadoc  for *PlanView::getReservations* says that it returns a *ReservationAllocation*
but you are actually returning a Set of ReservationAllocations

+1 Pending the above, [~subru]'s outstanding comments, the last two checkstyle warnings, and
a final run of Jenkins.

> Consider creating separate ACLs for Reservation create/update/delete/list ops
> -----------------------------------------------------------------------------
>
>                 Key: YARN-2575
>                 URL: https://issues.apache.org/jira/browse/YARN-2575
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, fairscheduler, resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Sean Po
>         Attachments: YARN-2575.v1.patch, YARN-2575.v10.patch, YARN-2575.v2.1.patch, YARN-2575.v2.patch,
YARN-2575.v3.patch, YARN-2575.v4.patch, YARN-2575.v5.patch, YARN-2575.v6.patch, YARN-2575.v7.patch,
YARN-2575.v8.patch, YARN-2575.v9.patch
>
>
> YARN-1051 introduces the ReservationSystem and in the current implementation anyone who
can submit applications can also submit reservations. This JIRA is to evaluate creating separate
ACLs for Reservation create/update/delete ops.
> Depends on YARN-4340



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message