hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2575) Consider creating separate ACLs for Reservation create/update/delete/list ops
Date Tue, 09 Feb 2016 03:15:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138272#comment-15138272

Subru Krishnan commented on YARN-2575:

Thanks [~seanpo03] for addressing my feedback. The latest patch looks very close, just a few
minor comments:
   * I discussed offline with [~asuresh] and [~curino], for simplicity let's follow that user
needs LIST_RESERVATIONS ACL for range list queries. This will simplify the code as we don't
need special ACL handling for list queries.
   * With the above proposal, we can reorder *ClientRMService::checkReservationACLs* for better
readability - first check if _ReservationACLManager is not null, then if the user is the owner,
followed by whether he/she has the appropriate ACLs and finally if user is admin or not.
   * Nit: some small copy-paste typos still in Javadocs 

> Consider creating separate ACLs for Reservation create/update/delete/list ops
> -----------------------------------------------------------------------------
>                 Key: YARN-2575
>                 URL: https://issues.apache.org/jira/browse/YARN-2575
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, fairscheduler, resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Sean Po
>         Attachments: YARN-2575.v1.patch, YARN-2575.v2.1.patch, YARN-2575.v2.patch, YARN-2575.v3.patch,
YARN-2575.v4.patch, YARN-2575.v5.patch, YARN-2575.v6.patch, YARN-2575.v7.patch, YARN-2575.v8.patch,
> YARN-1051 introduces the ReservationSystem and in the current implementation anyone who
can submit applications can also submit reservations. This JIRA is to evaluate creating separate
ACLs for Reservation create/update/delete ops.
> Depends on YARN-4340

This message was sent by Atlassian JIRA

View raw message