Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D160818820 for ; Thu, 21 Jan 2016 08:46:40 +0000 (UTC) Received: (qmail 22689 invoked by uid 500); 21 Jan 2016 08:46:40 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 22642 invoked by uid 500); 21 Jan 2016 08:46:40 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 22533 invoked by uid 99); 21 Jan 2016 08:46:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jan 2016 08:46:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E85C82C1F68 for ; Thu, 21 Jan 2016 08:46:39 +0000 (UTC) Date: Thu, 21 Jan 2016 08:46:39 +0000 (UTC) From: "Takashi Ohnishi (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4613) TestClientRMService#testGetClusterNodes fails occasionally MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110286#comment-15110286 ] Takashi Ohnishi commented on YARN-4613: --------------------------------------- I think this fails by too early checking before the node state really changed. {code:title=TestClientRMService.java} // Now make the node unhealthy. node.nodeHeartbeat(false); // Call again nodeReports = client.getClusterNodes(request).getNodeReports(); Assert.assertEquals("Unhealthy nodes should not show up by default", 0, nodeReports.size()); {code} How about adding a status check of NodeManager? I will attach a patch. > TestClientRMService#testGetClusterNodes fails occasionally > ---------------------------------------------------------- > > Key: YARN-4613 > URL: https://issues.apache.org/jira/browse/YARN-4613 > Project: Hadoop YARN > Issue Type: Sub-task > Components: test > Environment: jenkins > Reporter: Jason Lowe > > TestClientRMService has been failing occasionally on precommits. Sample failure: > {noformat} > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 > Running org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService > Tests run: 19, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 15.077 sec <<< FAILURE! - in org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService > testGetClusterNodes(org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService) Time elapsed: 0.551 sec <<< FAILURE! > java.lang.AssertionError: Unhealthy nodes should not show up by default expected:<0> but was:<1> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:555) > at org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService.testGetClusterNodes(TestClientRMService.java:215) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)