hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4617) LeafQueue#pendingOrderingPolicy should always use fixed ordering policy instead of using same as active applications ordering policy
Date Thu, 28 Jan 2016 22:49:40 GMT

    [ https://issues.apache.org/jira/browse/YARN-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122475#comment-15122475
] 

Jian He commented on YARN-4617:
-------------------------------

One more comment: I think for pending apps, we do not need to call addAllSchedulableEntities,
because the passed-in argument will always be empty ?
{code}
  public synchronized void setPendingAppsOrderingPolicy(
      OrderingPolicy<FiCaSchedulerApp> pendingOrderingPolicy) {
    if (null != this.pendingOrderingPolicy) {
      pendingOrderingPolicy
          .addAllSchedulableEntities(this.pendingOrderingPolicy
              .getSchedulableEntities());
    }
    this.pendingOrderingPolicy = pendingOrderingPolicy;
  }
{code}
 So we may just need to initialize the pendingOrderingPolicy variable, like this.
{code} this.pendingOrderingPolicy = new FifoOrderingPolicyForPendingApps(); {code}
Doing this, the CapacitySchedulerConfiguration#getPendingOrderingPolicy method can also be
removed 

> LeafQueue#pendingOrderingPolicy should always use fixed ordering policy instead of using
same as active applications ordering policy
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4617
>                 URL: https://issues.apache.org/jira/browse/YARN-4617
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler
>    Affects Versions: 2.8.0
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-4617.patch, 0001-YARN-4617.patch, 0002-YARN-4617.patch,
0003-YARN-4617.patch, 0004-YARN-4617.patch
>
>
> In discussion with [~leftnoteasy] in the JIRA [comment|https://issues.apache.org/jira/browse/YARN-4479?focusedCommentId=15108236&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15108236]
pointed out that {{LeafQueue#pendingOrderingPolicy}} should NOT be assumed to be same as active
applications ordering policy. It causes an issue when using fair ordering policy.
> Expectations of this JIRA should include
> # Create FifoOrderingPolicyForPendingApps which extends FifoOrderingPolicy.
> # Comparator of new ordering policy should use RecoveryComparator,PriorityComparator
and Fifocomparator in order respectively.
> # Clean up {{LeafQueue#pendingOPForRecoveredApps}} which is no more required once new
fixed ordering policy is created pending applications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message