hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
Date Tue, 19 Jan 2016 06:36:39 GMT

    [ https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106332#comment-15106332
] 

Varun Saxena commented on YARN-4596:
------------------------------------

[~Naganarasimha], [~gtCarrera9],

Regarding below comment,
bq. but if some one uses rest directly then some entities will get posted and some will not,
hence wanted to know whether its right to break in the middle ?
Not really.
*None of the entities will get posted to backend store.*

*BadRequestException* is thrown during entity preprocessing phase. Not during store put. We
first collect all the applicable entities which can be posted and then only call {{TimelineStore#put}}.
We are not calling put from within the loop. Refer to {{TimelineDataManager#doPostEntities}}.

It can although be argued that we can post entities which can be and send a put error(new
error type) for the entity which has no entity id or entity type. But if we do not have entity
id or type, how will client recognize which specific entity has failed from put error ? Maybe
they can cache entities which they have sent and then re-look at entities they attempted to
post and find out which ones had entity id and entity type missing. But will client be doing
so ? Current clients would be looking at entity id and type to find out which entities failed
and why.

Entity ID and type are key pieces of information in ATSv1. If client is not sending them,
it indicates some problem in the client side code. I think current code can be kept as it
is because this will be consistent with {{TimelineClient}} side code too where none of the
entities will be posted if entity id or type is missing in even one of them.
Thoughts ?





> SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-4596
>                 URL: https://issues.apache.org/jira/browse/YARN-4596
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Li Lu
>             Fix For: 2.8.0
>
>         Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch
>
>
> We should report error messages from the returned TimelineResponse when posting timeline
entities through system metric publisher. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message