hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
Date Sat, 16 Jan 2016 01:56:39 GMT

    [ https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102909#comment-15102909
] 

Naganarasimha G R commented on YARN-4596:
-----------------------------------------

Hi [~gtCarrera],
Overall the patch looks fine but few issues (not exactly related to this patch but just felt
lil related)
* {{JobHistoryEventHandler.processEventForTimelineServer}} is also swallowing the error message,
so may be we can handle in another jira?
* In {{TimelineDataManager.doPostEntities(TimelineEntities, UserGroupInformation)}} throws
*BadRequestException* when {{entity.getEntityId() == null || entity.getEntityType() == null}}
should this not be captured in  {{TimelinePutResponse.TimelinePutError}}  and continue with
next entity?

> SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-4596
>                 URL: https://issues.apache.org/jira/browse/YARN-4596
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch
>
>
> We should report error messages from the returned TimelineResponse when posting timeline
entities through system metric publisher. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message