hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
Date Fri, 15 Jan 2016 18:57:39 GMT

    [ https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102299#comment-15102299
] 

Li Lu commented on YARN-4596:
-----------------------------

Hi [~Naganarasimha] actually I was referring to the logic we have in the SMP itself, where
we simply do
{code}
      client.putEntities(entity);
{code}
when we actually post entities. However, timeline stores may put error messages in the response
to indicate failures/errors when putting these entities. The SMP needs to at least log down
those problems. Otherwise it's hard to reason about whether a putEntities call has actually
landed onto the timeline storage. 

The code you pointed out is on the client side, and is taking care of the case when there
is no (HTTP) response from the timeline server. If there are errors happened in timeline store,
the HTTP response should be fine but the actual TimelinePutResponse will contain the error
message. 

> SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-4596
>                 URL: https://issues.apache.org/jira/browse/YARN-4596
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Li Lu
>
> We should report error messages from the returned TimelineResponse when posting timeline
entities through system metric publisher. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message