hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4577) Enable aux services to have their own custom classpath/jar file
Date Thu, 14 Jan 2016 18:19:39 GMT

    [ https://issues.apache.org/jira/browse/YARN-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098556#comment-15098556
] 

Steve Loughran commented on YARN-4577:
--------------------------------------

Test wise

* {{testLoadAuxServiceLocally}} should be calling aux.close() in finally{} clauses. It's idempotent
so you could so a close() in the main path (and so test it), but still clean up after.
* it'd be nice for the asserts to include some text about why the asserts are failing, especially
simple {{assertTrue()}} calls. The goal is that enough information is printed to enable someone
who sees the Jenkins log to be able to diagnose the problem. An "assert failed line 315" doesn't
do that much, leads to the "add more test diagnostics" patches and more iterations.

> Enable aux services to have their own custom classpath/jar file
> ---------------------------------------------------------------
>
>                 Key: YARN-4577
>                 URL: https://issues.apache.org/jira/browse/YARN-4577
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.8.0
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-4577.1.patch, YARN-4577.2.patch
>
>
> Right now, users have to add their jars to the NM classpath directly, thus put them on
the system classloader. But if multiple versions of the plugin are present on the classpath,
there is no control over which version actually gets loaded. Or if there are any conflicts
between the dependencies introduced by the auxiliary service and the NM itself, they can break
the NM, the auxiliary service, or both.
> The solution could be: to instantiate aux services using a classloader that is different
from the system classloader.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message