hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4224) Support fetching entities by UID and change the REST interface to conform to current REST APIs' in YARN
Date Fri, 22 Jan 2016 18:55:40 GMT

    [ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112861#comment-15112861
] 

Varun Saxena commented on YARN-4224:
------------------------------------

Thanks [~gtCarrera9] for the review.

bq. Why we're changing TimelineReaderManager#getEntities from default to public? 
Not sure why I changed it to public. You are correct. Should be default.

bq. TimelineReaderUtil, maybe we'd like to have a separate class for those parse operations?

How does TimelineReaderWebServicesUtils sound ?

bq. TimelineReaderWebService#handleException, BadRequestException is a subclass of WebApplicationException
so you may want to remove it from the declaration.
Ok.

Will wait for your second round of review before updating the patch.


> Support fetching entities by UID and change the REST interface to conform to current
REST APIs' in YARN
> -------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4224
>                 URL: https://issues.apache.org/jira/browse/YARN-4224
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4224-YARN-2928.01.patch, YARN-4224-feature-YARN-2928.04.patch,
YARN-4224-feature-YARN-2928.05.patch, YARN-4224-feature-YARN-2928.wip.02.patch, YARN-4224-feature-YARN-2928.wip.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message