hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4224) Support fetching entities by UID and change the REST interface to conform to current REST APIs' in YARN
Date Thu, 21 Jan 2016 22:21:40 GMT

    [ https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111491#comment-15111491
] 

Li Lu commented on YARN-4224:
-----------------------------

Thanks [~varun_saxena]. The latest patch generally LGTM. Some minor comments:

1. Why we're changing TimelineReaderManager#getEntities from default to public? Do we plan
to make timeline reader manager to be visible to the outside world, or everyone should talk
to the reader server via its WS? 

2. TimelineReaderUtil, maybe we'd like to have a separate class for those parse operations?
Sometimes it's not easy to find out if a method is supported in util if we mix all of those
util methods inside a big util class. 

3. TimelineReaderWebService#handleException, BadRequestException is a subclass of WebApplicationException
so you may want to remove it from the declaration. 

I'd encourage everyone working on the branch to take a look at those proposed REST APIs. So
far I think they are fine, but I'd like to wait a day or two and think about them for one
more round. 

> Support fetching entities by UID and change the REST interface to conform to current
REST APIs' in YARN
> -------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4224
>                 URL: https://issues.apache.org/jira/browse/YARN-4224
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4224-YARN-2928.01.patch, YARN-4224-feature-YARN-2928.04.patch,
YARN-4224-feature-YARN-2928.05.patch, YARN-4224-feature-YARN-2928.wip.02.patch, YARN-4224-feature-YARN-2928.wip.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message