Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB95E18DA1 for ; Thu, 10 Dec 2015 03:44:11 +0000 (UTC) Received: (qmail 8575 invoked by uid 500); 10 Dec 2015 03:44:11 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 8526 invoked by uid 500); 10 Dec 2015 03:44:11 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 8510 invoked by uid 99); 10 Dec 2015 03:44:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2015 03:44:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1C0A92C1F68 for ; Thu, 10 Dec 2015 03:44:11 +0000 (UTC) Date: Thu, 10 Dec 2015 03:44:11 +0000 (UTC) From: "Naganarasimha G R (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049982#comment-15049982 ] Naganarasimha G R commented on YARN-4356: ----------------------------------------- Hi [~sjlee0], bq. Right now those null checks are still limited to a couple of files. Although it may not be ideal, it is still manageable? Its not a blocking thing and its just will help it in keeping it clean so no issues we can go ahead for this patch will try to take care in one of my other patches related to NMMetricsPublisher. bq. Hmm, I know it's not great having 2 similar-sounding config params, but there is also RM_SYSTEM_METRICS_PUBLISHER_DISPATCHER_POOL_SIZE, so this might also make this patch a little bigger. Ok we can take care in another jira, but YarnConfiguration.SYSTEM_METRICS_PUBLISHER_ENABLED and YarnConfiguration.RM_SYSTEM_METRICS_PUBLISHER_ENABLED was introduced because version was not there . > ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off > ------------------------------------------------------------------------------------------ > > Key: YARN-4356 > URL: https://issues.apache.org/jira/browse/YARN-4356 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Affects Versions: YARN-2928 > Reporter: Sangjin Lee > Assignee: Sangjin Lee > Priority: Critical > Labels: yarn-2928-1st-milestone > Attachments: YARN-4356-feature-YARN-2928.002.patch, YARN-4356-feature-YARN-2928.003.patch, YARN-4356-feature-YARN-2928.004.patch, YARN-4356-feature-YARN-2928.005.patch, YARN-4356-feature-YARN-2928.poc.001.patch > > > For us to be able to merge the first milestone drop to trunk, we want to ensure that once disabled the timeline service v.2 has no impact from the server side to the client side. If the timeline service is not enabled, no action should be done. If v.1 is enabled but not v.2, v.1 should behave the same as it does before the merge. -- This message was sent by Atlassian JIRA (v6.3.4#6332)