Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Tue, 29 Dec 2015 21:44:49 +0000 (UTC)
From: "Wangda Tan (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12904287.1444682511000.24281.1451425489704@Atlassian.JIRA>
In-Reply-To: <JIRA.12904287.1444682511000@Atlassian.JIRA>
References: <JIRA.12904287.1444682511000@Atlassian.JIRA>
 <JIRA.12904287.1444682511092@arcas>
Subject: [jira] [Commented] (YARN-4257) Move scheduler validateConf method
 to AbstractYarnScheduler and make it protected
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074334#comment-15074334 ] 

Wangda Tan commented on YARN-4257:
----------------------------------

Thanks [~rhaase],

Patch looks good to me.

[~kasha], since the patch changes minimum allocation checking of FairScheduler, do you want to look at the patch?

> Move scheduler validateConf method to AbstractYarnScheduler and make it protected
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-4257
>                 URL: https://issues.apache.org/jira/browse/YARN-4257
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>            Reporter: Swapnil Daingade
>            Assignee: Rich Haase
>              Labels: easyfix
>         Attachments: YARN-4257.patch
>
>
> Currently FairScheduler, CapacityScheduler and FifoScheduler each have a method private void validateConf(Configuration conf).
> All three methods validate the minimum and maximum scheduler allocations for cpu and memory (with minor difference). FairScheduler supports 0 as minimum allocation for cpu and memory, while CapacityScheduler and FifoScheduler do not. We can move this code to AbstractYarnScheduler (avoids code duplication) and make it protected for individual schedulers to override.
> Why do we care about a minimum allocation of 0 for cpu and memory?
> We contribute to a project called Apache Myriad that run yarn on mesos. Myriad supports a feature call fine grained scaling (fgs). In fgs, a NM is launched with zero capacity (0 cpu and 0 mem). When a yarn container is to be run on the NM, a mesos offer for that node is accepted and the NM capacity is dynamically scaled up to match the accepted mesos offer. On completion of the yarn container, resources are returned back to Mesos and the NM capacity is scaled down back to zero (cpu & mem). 
> In ResourceTrackerService.registerNodeManager, yarn checks if the NM capacity is at-least as much as yarn.scheduler.minimum-allocation-mb and yarn.scheduler.minimum-allocation-vcores. These values can be set to 0 in yarn-site.xml (so a zero capacity NM is possible). However, the validateConf methods in CapacityScheduler and FifoScheduler do not allow for 0 values for these properties (The FairScheduler one does allow for 0). This behaviour should be consistent or at-least be override able.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)