Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8A1E1189B2 for ; Fri, 18 Dec 2015 01:05:47 +0000 (UTC) Received: (qmail 51082 invoked by uid 500); 18 Dec 2015 01:05:47 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 51026 invoked by uid 500); 18 Dec 2015 01:05:47 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 50753 invoked by uid 99); 18 Dec 2015 01:05:47 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Dec 2015 01:05:47 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C80EC2C1F7B for ; Fri, 18 Dec 2015 01:05:46 +0000 (UTC) Date: Fri, 18 Dec 2015 01:05:46 +0000 (UTC) From: "MENG DING (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4138) Roll back container resource allocation after resource increase token expires MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063209#comment-15063209 ] MENG DING commented on YARN-4138: --------------------------------- Thanks [~sandflee] for the review. bq. use Resources.fitsin(targetResource, lastConfirmedResource)? Will do bq. update lastConfirmedResource in RMContainer? and log debug to log info? We should not update lastConfirmedResource in this scenario. This is the exact case we want to cover in this ticket, where the resource increase token may expire, and we need to roll back to the old resource. The only time we want to update lastConfirmedResource during resource increase is when Resources.equals(nmContainerResource, rmContainerResource). bq. If am increase a containerA 1G -> 2G, and recieved a new container B, and have not told NM if am wants to decrease it to 500M, when using requestContainerResourceChange(Container container, Resource capability) , seems we should use container B? Sorry I don't understand the question. Can you elaborate? Thanks, Meng > Roll back container resource allocation after resource increase token expires > ----------------------------------------------------------------------------- > > Key: YARN-4138 > URL: https://issues.apache.org/jira/browse/YARN-4138 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, nodemanager, resourcemanager > Reporter: MENG DING > Assignee: MENG DING > Attachments: YARN-4138-YARN-1197.1.patch, YARN-4138-YARN-1197.2.patch > > > In YARN-1651, after container resource increase token expires, the running container is killed. > This ticket will change the behavior such that when a container resource increase token expires, the resource allocation of the container will be reverted back to the value before the increase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)