From yarn-issues-return-74706-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Thu Dec 3 16:04:46 2015 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 28AC218C18 for ; Thu, 3 Dec 2015 16:04:46 +0000 (UTC) Received: (qmail 46562 invoked by uid 500); 3 Dec 2015 16:04:11 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 46430 invoked by uid 500); 3 Dec 2015 16:04:11 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 46316 invoked by uid 99); 3 Dec 2015 16:04:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Dec 2015 16:04:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 189EB2C1F71 for ; Thu, 3 Dec 2015 16:04:11 +0000 (UTC) Date: Thu, 3 Dec 2015 16:04:11 +0000 (UTC) From: "Sunil G (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4405) Support node label store in non-appendable file system MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037993#comment-15037993 ] Sunil G commented on YARN-4405: ------------------------------- Hi [~leftnoteasy] Thank you for starting this ticket. Couple of minor points: 1. Can mirror.new.tmp also pre-exists is the system (may be RM crashed earlier just after creating this file) 2. I feel may be {{close()}} need to be overridden. Otherwise for NonAppendableFSNodeLabelStore, we will still have base implementation to close {{editlogOs}} which is not needed. {code} IOUtils.cleanup(LOG, fs, editlogOs); {code} 3. May be some logs at the end of {{NonAppendableFSNodeLabelStore#recover}} can help to provide some info that file creation/deletion/modification is done successfully. > Support node label store in non-appendable file system > ------------------------------------------------------ > > Key: YARN-4405 > URL: https://issues.apache.org/jira/browse/YARN-4405 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, client, resourcemanager > Reporter: Wangda Tan > Assignee: Wangda Tan > Attachments: YARN-4405.1.patch, YARN-4405.2.patch, YARN-4405.3.patch > > > Existing node label file system store implementation uses append to write edit logs. However, some file system doesn't support append, we need add an implementation to support such non-appendable file systems as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)