From yarn-issues-return-75077-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Tue Dec 8 15:21:47 2015 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 436AD181BD for ; Tue, 8 Dec 2015 15:21:47 +0000 (UTC) Received: (qmail 39501 invoked by uid 500); 8 Dec 2015 15:21:11 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 39215 invoked by uid 500); 8 Dec 2015 15:21:11 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 38888 invoked by uid 99); 8 Dec 2015 15:21:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Dec 2015 15:21:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 10E572C1F79 for ; Tue, 8 Dec 2015 15:21:11 +0000 (UTC) Date: Tue, 8 Dec 2015 15:21:11 +0000 (UTC) From: "Sunil G (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046961#comment-15046961 ] Sunil G commented on YARN-4403: ------------------------------- Hi [~djp] Thanks for the updated patch. I have one doubt here, we could see tat {{SystemClock#getTime}} is *Public* and *Stable*. Now there is a note saying that its advisable to use {{MonotonicClock}}, so any annotation change is needed for {{SystemClock}}? > (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period > ------------------------------------------------------------------------------------ > > Key: YARN-4403 > URL: https://issues.apache.org/jira/browse/YARN-4403 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Junping Du > Assignee: Junping Du > Priority: Critical > Attachments: YARN-4403-v2.patch, YARN-4403.patch > > > Currently, (AM/NM/Container)LivelinessMonitor use current system time to calculate a duration of expire which could be broken by settimeofday. We should use Time.monotonicNow() instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)