hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4405) Support node label store in non-appendable file system
Date Thu, 03 Dec 2015 16:04:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037993#comment-15037993
] 

Sunil G commented on YARN-4405:
-------------------------------

Hi [~leftnoteasy]
Thank you for starting this ticket.

Couple of minor points:
1. Can mirror.new.tmp also pre-exists is the system (may be RM crashed earlier just after
creating this file)
2. I feel may be {{close()}} need to be overridden. Otherwise for NonAppendableFSNodeLabelStore,
we will still have base implementation to close {{editlogOs}} which is not needed.
{code}
    IOUtils.cleanup(LOG, fs, editlogOs);
{code}
3. May be some logs at the end of {{NonAppendableFSNodeLabelStore#recover}} can help to provide
some info that file creation/deletion/modification is done successfully.


> Support node label store in non-appendable file system
> ------------------------------------------------------
>
>                 Key: YARN-4405
>                 URL: https://issues.apache.org/jira/browse/YARN-4405
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-4405.1.patch, YARN-4405.2.patch, YARN-4405.3.patch
>
>
> Existing node label file system store implementation uses append to write edit logs.
However, some file system doesn't support append, we need add an implementation to support
such non-appendable file systems as well. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message