hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4381) Add container launchEvent and container localizeFailed metrics in container
Date Tue, 08 Dec 2015 14:56:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046933#comment-15046933
] 

Hadoop QA commented on YARN-4381:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 11s {color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s {color} |
{color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s {color} |
{color:green} trunk passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s {color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 31s {color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s {color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 0s {color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s {color} |
{color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s {color} |
{color:green} trunk passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 30s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s {color} |
{color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 26s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s {color} |
{color:green} the patch passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s {color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s {color} | {color:red}
Patch generated 4 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
(total was 116, now 120). {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 32s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 9s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s {color} |
{color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s {color} |
{color:green} the patch passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m 59s {color} | {color:green}
hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m 27s {color} | {color:green}
hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_85. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 20s {color} | {color:red}
Patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 36m 3s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12776320/YARN-4381.002.patch
|
| JIRA Issue | YARN-4381 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  findbugs
 checkstyle  |
| uname | Linux 767fc930d7b8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / fc47084 |
| findbugs | v3.0.0 |
| checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/9899/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
|
| JDK v1.7.0_85  Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/9899/testReport/
|
| asflicense | https://builds.apache.org/job/PreCommit-YARN-Build/9899/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager |
| Max memory used | 75MB |
| Powered by | Apache Yetus    http://yetus.apache.org |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/9899/console |


This message was automatically generated.



> Add container launchEvent and container localizeFailed metrics in container
> ---------------------------------------------------------------------------
>
>                 Key: YARN-4381
>                 URL: https://issues.apache.org/jira/browse/YARN-4381
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.7.1
>            Reporter: Lin Yiqun
>            Assignee: Lin Yiqun
>         Attachments: YARN-4381.001.patch, YARN-4381.002.patch
>
>
> Recently, I found a issue on nodemanager metrics.That's {{NodeManagerMetrics#containersLaunched}}
is not actually means the container succeed launched times.Because in some time, it will be
failed when receiving the killing command or happening container-localizationFailed.This will
lead to a failed container.But now,this counter value will be increased in these code whenever
the container is started successfully or failed.
> {code}
> Credentials credentials = parseCredentials(launchContext);
>     Container container =
>         new ContainerImpl(getConfig(), this.dispatcher,
>             context.getNMStateStore(), launchContext,
>           credentials, metrics, containerTokenIdentifier);
>     ApplicationId applicationID =
>         containerId.getApplicationAttemptId().getApplicationId();
>     if (context.getContainers().putIfAbsent(containerId, container) != null) {
>       NMAuditLogger.logFailure(user, AuditConstants.START_CONTAINER,
>         "ContainerManagerImpl", "Container already running on this node!",
>         applicationID, containerId);
>       throw RPCUtil.getRemoteException("Container " + containerIdStr
>           + " already is running on this node!!");
>     }
>     this.readLock.lock();
>     try {
>       if (!serviceStopped) {
>         // Create the application
>         Application application =
>             new ApplicationImpl(dispatcher, user, applicationID, credentials, context);
>         if (null == context.getApplications().putIfAbsent(applicationID,
>           application)) {
>           LOG.info("Creating a new application reference for app " + applicationID);
>           LogAggregationContext logAggregationContext =
>               containerTokenIdentifier.getLogAggregationContext();
>           Map<ApplicationAccessType, String> appAcls =
>               container.getLaunchContext().getApplicationACLs();
>           context.getNMStateStore().storeApplication(applicationID,
>               buildAppProto(applicationID, user, credentials, appAcls,
>                 logAggregationContext));
>           dispatcher.getEventHandler().handle(
>             new ApplicationInitEvent(applicationID, appAcls,
>               logAggregationContext));
>         }
>         this.context.getNMStateStore().storeContainer(containerId, request);
>         dispatcher.getEventHandler().handle(
>           new ApplicationContainerInitEvent(container));
>         this.context.getContainerTokenSecretManager().startContainerSuccessful(
>           containerTokenIdentifier);
>         NMAuditLogger.logSuccess(user, AuditConstants.START_CONTAINER,
>           "ContainerManageImpl", applicationID, containerId);
>         // TODO launchedContainer misplaced -> doesn't necessarily mean a container
>         // launch. A finished Application will not launch containers.
>         metrics.launchedContainer();
>         metrics.allocateContainer(containerTokenIdentifier.getResource());
>       } else {
>         throw new YarnException(
>             "Container start failed as the NodeManager is " +
>             "in the process of shutting down");
>       }
> {code}
> In addition, we are lack of localzationFailed metric in container.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message