hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off
Date Thu, 10 Dec 2015 11:54:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050645#comment-15050645
] 

Junping Du commented on YARN-4356:
----------------------------------

Thanks [~sjlee0] for updating the patch! 
bq. This is the java 7 diamond operator (<>) which is a shorthand for inferring types.
The type information is NOT removed. It's inferred by the compiler, and the compiler produces
the same bytecode as specifying the types.
Got it. Sounds like my coffee is stale and I need a new cup. :)

bq. Got it. Can we proceed with the current patch and get that fix once YARN-3586 goes in?
Sure. Just a reminder here as I also forget it myself.

bq. This is addressing a javadoc error. The ampersand ("&") is a special character for
javadoc, and it breaks javadoc. It needs to be entity-escaped.
Oh. I see. Let's keep it here.

bq. This is used for the test method launchServer(). This method is invoked directly by a
unit test (thus the @VisibleForTesting annotation). The same for TimelineReaderServer.
If so, I would prefer not to update configuration in launchServer(), but pass a updated configuration
to the method instead, just as other daemons (RM, NM) doing. The reason is it could be hard
to track the real configurations for daemons/services if we override them in internal logic.
May be we should follow the same practices?

bq. That's fine. I still put up the patch that includes a version of that because without
it things won't even compile. I will wait until YARN-3623 goes in before I remove that piece
from this patch, then this can get committed.
Sounds good. I just commit YARN-3623 to trunk.

Other looks good to me in 005 patch.

> ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned
off
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-4356
>                 URL: https://issues.apache.org/jira/browse/YARN-4356
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>            Priority: Critical
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4356-feature-YARN-2928.002.patch, YARN-4356-feature-YARN-2928.003.patch,
YARN-4356-feature-YARN-2928.004.patch, YARN-4356-feature-YARN-2928.005.patch, YARN-4356-feature-YARN-2928.poc.001.patch
>
>
> For us to be able to merge the first milestone drop to trunk, we want to ensure that
once disabled the timeline service v.2 has no impact from the server side to the client side.
If the timeline service is not enabled, no action should be done. If v.1 is enabled but not
v.2, v.1 should behave the same as it does before the merge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message