hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vrushali C (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4356) ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned off
Date Fri, 04 Dec 2015 20:27:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042180#comment-15042180
] 

Vrushali C commented on YARN-4356:
----------------------------------


Thanks Sangjin for the initial patch! I had a few discussion points.

- +1 on creating a FlowContext. Could we add user as a class member too? 

- Do we want to put in a check if timeline v2 is enabled in the hbase writer and reader too?


- at line 274 in JobHistoryEventHandler
- MRJobConfig.MAPREDUCE_JOB_NEW_TIMELINE_SERVICE_ENABLED
I see that this code is in the map reduce context since most other variables are MAPREDUCE_something
but do you think we should also check the Yarn Config variable? Or is that not visible in
this code. 
Else we would need to set two config variables one being MRJobConfig.MAPREDUCE_JOB_NEW_TIMELINE_SERVICE_ENABLED
and the other YarnConfiguration.TIMELINE_SERVICE_ENABLED ?
- Also the logging messages on lines 275 and 276 perhaps need to be updated?

- In ApplicationMaster.java, it looks like some of the functions are no longer static. I did
see that you mentioned that all the unit tests pass but if we change this, would any user
code break? For folks who write their own app master?  Or perhaps the unit tests cover that
case.

- at line 357 in TimelineClientImpl.java, do we want to throw an exception or log a warning
and return? If we throw an error, would existing apps break if they are to be run without
recompilation for the new client. 



> ensure the timeline service v.2 is disabled cleanly and has no impact when it's turned
off
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-4356
>                 URL: https://issues.apache.org/jira/browse/YARN-4356
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>            Priority: Critical
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4356-feature-YARN-2928.poc.001.patch
>
>
> For us to be able to merge the first milestone drop to trunk, we want to ensure that
once disabled the timeline service v.2 has no impact from the server side to the client side.
If the timeline service is not enabled, no action should be done. If v.1 is enabled but not
v.2, v.1 should behave the same as it does before the merge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message