hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4225) Add preemption status to yarn queue -status for capacity scheduler
Date Wed, 02 Dec 2015 18:27:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036317#comment-15036317
] 

Wangda Tan commented on YARN-4225:
----------------------------------

[~eepayne],

Thanks for working on the patch, few comments:

1)
bq. public abstract Boolean getPreemptionDisabled();
Do you think is it better to return boolean? I'd prefer to return a default value (false)
instead of return null

2) 
For QueueCLI, is it better to print "preemption is disabled/enabled" instead of "preemption
status: disabled/enabled"?

3)
Is it possible to add a simple test to verify end-to-end behavior?

> Add preemption status to yarn queue -status for capacity scheduler
> ------------------------------------------------------------------
>
>                 Key: YARN-4225
>                 URL: https://issues.apache.org/jira/browse/YARN-4225
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler, yarn
>    Affects Versions: 2.7.1
>            Reporter: Eric Payne
>            Assignee: Eric Payne
>            Priority: Minor
>         Attachments: YARN-4225.001.patch, YARN-4225.002.patch, YARN-4225.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message