hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dian Fu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4100) Add Documentation for Distributed and Delegated-Centralized Node Labels feature
Date Fri, 11 Dec 2015 08:34:10 GMT

    [ https://issues.apache.org/jira/browse/YARN-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052411#comment-15052411
] 

Dian Fu commented on YARN-4100:
-------------------------------

Hi [~Naganarasimha],
Thanks a lot for patch. LGTM. Just a few minor comments:
* {{Script}} should be {{script}}.
* {{NM will send its loaded labels every x intervals configured along with heartbeat from
NM to RM.}} can be changed to {{NM will send its loaded labels every x intervals configured
along with heartbeat to RM.}}. 
* {quote}
By default 2 implementations are supported, Script and Configuration based
  {quote}
What about {{By default 2 implementations are supported: Script based and Configuration based}}?
* {quote}
In case of Script,......In case of config,
 {quote}
The capital of {{script}} and {{config}} should be consistent.
* {{This would helpfull}} can be changed to {{This would be helpfull}}
* {quote}"delegated-centralized" needs to be set, to fetch the labels from a interface in
RM.}} {quote}
The comma can be removed.
* {quote} When "yarn.node-labels.configuration-type" parameter in RM is configured as "distributed",
{quote}
What about changed to {{When "yarn.node-labels.configuration-type" is configured with "distributed"}}
* {quote}If "config" is specified then "ConfigurationNodeLabelsProvider" and "script" then
"ScriptNodeLabelsProvider" will be used.{quote}
What about changed to {{If "config" is configured, then "ConfigurationNodeLabelsProvider"
will be used and if "script" is configured, then "ScriptNodeLabelsProvider" will be used.}}
* {quote}admin might have removed the cluster label which was provided NM{quote}
Missed one word {{by}} between {{provided}} and {{NM}}.
* {quote} This configuration is to define the interval period.If -1 is configured{quote}
Missed one white space before {{If}}.
* {{When....then}}, {{If...then}}
I think there should be one comma before then.
* {{will be considered for Node Labels.}}
Seems that it should be {{will be considered as Node Labels.}}
* {{ In case of multiple lines having the pattern, last one will be considered.}}
What about {{In case that multiple lines have this pattern, the last line will be considered.}}

> Add Documentation for Distributed and Delegated-Centralized Node Labels feature
> -------------------------------------------------------------------------------
>
>                 Key: YARN-4100
>                 URL: https://issues.apache.org/jira/browse/YARN-4100
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: NodeLabel.html, YARN-4100.v1.001.patch
>
>
> Add Documentation for Distributed Node Labels feature



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message