hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gera Shegalov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2934) Improve handling of container's stderr
Date Wed, 16 Dec 2015 12:51:46 GMT

    [ https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059943#comment-15059943
] 

Gera Shegalov commented on YARN-2934:
-------------------------------------

Hi [~Naganarasimha],
Please make sure that the patch does not introduce new problems. Both checkstyle and findbugs
report problems related to the patch. Check the Hadoop QA comment above. Keep addressing the
newly introduced issues without waiting for review to simplify the review process. 

I suggest to use globs instead of regexes, so you can simply call FileSystem#globStatus. The
path pattern could be something like {code}{*stderr*,*STDERR*}{code} or maybe {code}{*err,*ERR,*out,*OUT}{code}.
I'd rather have a longer config value than adding more code to make patterns case-insensitive.
In practice we mostly need stderr

Not sure how fancy we need to be with the case where multiple log files qualify for the pattern,
but maybe at least mention to the user there are more files to look at. 

In general, don't try optimize for the failure case. Things like
{code}
private static long tailSizeInBytes = -1;
{code}
look like a bug. Simply get it from conf exactly when it's needed.


> Improve handling of container's stderr 
> ---------------------------------------
>
>                 Key: YARN-2934
>                 URL: https://issues.apache.org/jira/browse/YARN-2934
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Gera Shegalov
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-2934.v1.001.patch, YARN-2934.v1.002.patch, YARN-2934.v1.003.patch,
YARN-2934.v1.004.patch, YARN-2934.v1.005.patch, YARN-2934.v1.006.patch
>
>
> Most YARN applications redirect stderr to some file. That's why when container launch
fails with {{ExitCodeException}} the message is empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message