hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2575) Consider creating separate ACLs for Reservation create/update/delete/list ops
Date Wed, 16 Dec 2015 21:20:46 GMT

    [ https://issues.apache.org/jira/browse/YARN-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060892#comment-15060892
] 

Subru Krishnan commented on YARN-2575:
--------------------------------------

Thanks [~seanpo03] for taking this up, this is an important patch.

I took a look at your patch and have a few suggestions to simplify it:
  * Let us move the *ReservationACLs* to the *ReservationSystem* and add a getter. With this
approach, we need not change the _RM_ or _ClientRMService_ constructor, a non-trivial chunk
of the patch is addressing the resulting conflicts.
  * We should add an explicit ACL for *LIST_RESERVATIONS* to avoid the convoluted implied
if checks.
  * I feel that we can replace the checks in the _Scheduler/Queue_ hierarchy with one in the
*ClientRMService::submitApp*.
  * The changes in the scheduler xml files are not needed as the _ReservationSystem_ is not
enabled by default yet.
  * In *ACLsTestBase*, you can refer to *TestReservationSystemWithRMHA::addNodeCapacityToPlan*
for draining the dispatcher to ensure node is registered with RM.

> Consider creating separate ACLs for Reservation create/update/delete/list ops
> -----------------------------------------------------------------------------
>
>                 Key: YARN-2575
>                 URL: https://issues.apache.org/jira/browse/YARN-2575
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, fairscheduler, resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Sean Po
>         Attachments: YARN-2575.v1.patch
>
>
> YARN-1051 introduces the ReservationSystem and in the current implementation anyone who
can submit applications can also submit reservations. This JIRA is to evaluate creating separate
ACLs for Reservation create/update/delete ops.
> Depends on YARN-4340



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message