hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2575) Consider creating separate ACLs for Reservation create/update/delete/list ops
Date Tue, 29 Dec 2015 21:17:49 GMT

    [ https://issues.apache.org/jira/browse/YARN-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074307#comment-15074307
] 

Subru Krishnan commented on YARN-2575:
--------------------------------------

Thanks @Sean Po for the updated patch. It looks mostly good to me, just a few minor comments:
  * Typo in Javadocs for *ReservationACL::LIST_RESERVATIONS*
  * Unrelated formatting changes in *ClientRMService*
  * In *ClientRMService::submitApplication*, handle null i.e. reservation id not being present
in _Plan_
  * _rmContext.getReservationSystem()_ is redudant as we already hold a reference to reservation
system if enabled, so can be used directly
  * *YarnScheduler* should not be part of the patch
  * We should return the default ACLs, i.e. everyone has access in *ReservationSchedulerConfiguration::getReservationAcls*
  * Override tag missing in child classes for _getReservationAcls_

> Consider creating separate ACLs for Reservation create/update/delete/list ops
> -----------------------------------------------------------------------------
>
>                 Key: YARN-2575
>                 URL: https://issues.apache.org/jira/browse/YARN-2575
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, fairscheduler, resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Sean Po
>         Attachments: YARN-2575.v1.patch, YARN-2575.v2.1.patch, YARN-2575.v2.patch, YARN-2575.v3.patch
>
>
> YARN-1051 introduces the ReservationSystem and in the current implementation anyone who
can submit applications can also submit reservations. This JIRA is to evaluate creating separate
ACLs for Reservation create/update/delete ops.
> Depends on YARN-4340



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message