Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8ADE218800 for ; Thu, 12 Nov 2015 23:22:11 +0000 (UTC) Received: (qmail 629 invoked by uid 500); 12 Nov 2015 23:22:11 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 417 invoked by uid 500); 12 Nov 2015 23:22:11 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 359 invoked by uid 99); 12 Nov 2015 23:22:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2015 23:22:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 099A92C1F62 for ; Thu, 12 Nov 2015 23:22:11 +0000 (UTC) Date: Thu, 12 Nov 2015 23:22:11 +0000 (UTC) From: "zhihai xu (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4344) NMs reconnecting with changed capabilities can lead to wrong cluster resource calculations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003181#comment-15003181 ] zhihai xu commented on YARN-4344: --------------------------------- +1 for Jason Lowe's suggestion to fix the issue at scheduler side. Using {{SchedulerNode.getTotalResource()}} instead of {{RMNode.getTotalCapability()}} inside Scheduler can better decouple Scheduler from RMNodeImpl state machine. It may also fix some other potential issues. For example, {{CapacityScheduler#addNode}} uses {{nodeManager.getTotalCapability()}} after creating {{FiCaSchedulerNode}}, if {{nodeManager.totalCapability}} is changed by RMNodeImpl state machine right after {{FiCaSchedulerNode}} was created, similar issue may happen. > NMs reconnecting with changed capabilities can lead to wrong cluster resource calculations > ------------------------------------------------------------------------------------------ > > Key: YARN-4344 > URL: https://issues.apache.org/jira/browse/YARN-4344 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Affects Versions: 2.7.1, 2.6.2 > Reporter: Varun Vasudev > Assignee: Varun Vasudev > Priority: Critical > Attachments: YARN-4344.001.patch > > > After YARN-3802, if an NM re-connects to the RM with changed capabilities, there can arise situations where the overall cluster resource calculation for the cluster will be incorrect leading to inconsistencies in scheduling. -- This message was sent by Atlassian JIRA (v6.3.4#6332)