hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4338) NPE in RegularContainerAllocator.preCheckForNewContainer()
Date Mon, 09 Nov 2015 23:34:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997654#comment-14997654
] 

Wangda Tan commented on YARN-4338:
----------------------------------

Thanks for comments: [~sunilg]/[~Naganarasimha].

[~xinwei], I would prefer to keep main logic as-is and fix tests, the major concern is people
may think node label expression required to check null in CS logic, which could reduce code
readability. I'm OK with common code (such as AppSchedulingInfo) check null for nodeLabelExpression.
Could you fix tests of YARN-2618 instead of updating RegularContainerAllocator?

> NPE in RegularContainerAllocator.preCheckForNewContainer()
> ----------------------------------------------------------
>
>                 Key: YARN-4338
>                 URL: https://issues.apache.org/jira/browse/YARN-4338
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Xinwei Qin 
>            Priority: Minor
>         Attachments: YARN-4338.001.patch
>
>
> The codes in RegularContainerAllocator.preCheckForNewContainer():
> {code}
>     if (anyRequest.getNodeLabelExpression()
>         .equals(RMNodeLabelsManager.NO_LABEL)) {
>       missedNonPartitionedRequestSchedulingOpportunity =
>           application
>               .addMissedNonPartitionedRequestSchedulingOpportunity(priority);
>     }
> {code}
> {code}anyRequest.getNodeLabelExpression(){code}may return null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message