hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4279) Mark ApplicationId and ApplicationAttemptId static methods as @Public, @Unstable
Date Wed, 18 Nov 2015 22:18:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-4279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012169#comment-15012169
] 

Hudson commented on YARN-4279:
------------------------------

FAILURE: Integrated in Hadoop-Yarn-trunk #1419 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1419/])
YARN-4279. Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a)
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java
* hadoop-yarn-project/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java


> Mark ApplicationId and ApplicationAttemptId static methods as @Public, @Unstable
> --------------------------------------------------------------------------------
>
>                 Key: YARN-4279
>                 URL: https://issues.apache.org/jira/browse/YARN-4279
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 2.7.1
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: YARN-4279-001.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> The classes {{ApplicationId}} and {{ApplicationAttemptId}} both have {{newInstance()}}
methods tagged as {{@Private}}. Yet they are useful in testing, as the alternative is to create
and configure the PBImpl classes -which are significantly more private.
> The fact that mapreduce's {{MRBuilderUtils}} uses one of the methods shows that YARN
apps do need access to the methods.
> Marking them as public would make it clear that other YARN apps were using them for their
production or test code, rather than today, where they are used and depended on, yet without
the YARN team's knowledge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message