hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4053) Change the way metric values are stored in HBase Storage
Date Thu, 19 Nov 2015 02:04:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012620#comment-15012620
] 

Sangjin Lee commented on YARN-4053:
-----------------------------------

Yes, I spoke with [~jrottinghuis] regarding the stronger type safety suggestion. I'm now more
or less comfortable with the current version. The additional type safety you get is probably
minimal, and can cause bit more headache as a side effect as Joep mentioned.

Just for the record, I tinkered with this a little bit, and there seems to be a way to do
this safely. The assumption is {{add()}} and {{compare()}} are invoked only on the return
values of {{decodeValue()}}. That is currently the case, but it might not always be true.
In any case, if that were always true, we could do

{code}
public interface ValueConverter<T> {
  byte[] encodeValue(Object value) throws IOException; // this value is still object
  T decodeValue(byte[] bytes) throws IOException;
}

public interface NumericValueConverter<T extends Number>
    extends ValueConverter<T>, Comparator<T> {
  T add(T num1, T num2);
}

public class LongConverter implements NumericValueConverter<Long> {
  ...
}
{code}

This is basically tying the loop from {{decodeValue()}} and {{add()}} and {{compare()}}. Again,
this is a mild suggestion at this point, and it works only if the assumption that {{add()}}
and {{compare()}} work only on the result of {{decodeValue()}} is true.

> Change the way metric values are stored in HBase Storage
> --------------------------------------------------------
>
>                 Key: YARN-4053
>                 URL: https://issues.apache.org/jira/browse/YARN-4053
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4053-YARN-2928.01.patch, YARN-4053-YARN-2928.02.patch, YARN-4053-feature-YARN-2928.03.patch,
YARN-4053-feature-YARN-2928.04.patch, YARN-4053-feature-YARN-2928.05.patch
>
>
> Currently HBase implementation uses GenericObjectMapper to convert and store values in
backend HBase storage. This converts everything into a string representation(ASCII/UTF-8 encoded
byte array).
> While this is fine in most cases, it does not quite serve our use case for metrics. 
> So we need to decide how are we going to encode and decode metric values and store them
in HBase.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message