Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CBA0A18C81 for ; Tue, 13 Oct 2015 09:02:05 +0000 (UTC) Received: (qmail 70229 invoked by uid 500); 13 Oct 2015 09:02:05 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 70178 invoked by uid 500); 13 Oct 2015 09:02:05 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 70164 invoked by uid 99); 13 Oct 2015 09:02:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Oct 2015 09:02:05 +0000 Date: Tue, 13 Oct 2015 09:02:05 +0000 (UTC) From: "Steve Loughran (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4259) NPE inTestAMRMClientOnRMRestart.testAMRMClientResendsRequestsOnRMRestart MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954663#comment-14954663 ] Steve Loughran commented on YARN-4259: -------------------------------------- +reviewing the test, the final {{service.stop()}} calls must go into a try/finally block, so if the test raises an exception, the services still halt > NPE inTestAMRMClientOnRMRestart.testAMRMClientResendsRequestsOnRMRestart > ------------------------------------------------------------------------ > > Key: YARN-4259 > URL: https://issues.apache.org/jira/browse/YARN-4259 > Project: Hadoop YARN > Issue Type: Bug > Components: test > Affects Versions: 2.8.0 > Environment: Jenkins > Reporter: Steve Loughran > Assignee: Bibin A Chundatt > Priority: Critical > > NPE in {{TestAMRMClientOnRMRestart.testAMRMClientResendsRequestsOnRMRestart}}; root cause looks like changes in YARN-4140. Code for testing node label changes need to handle null labels in requests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)