Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7F48917F3E for ; Thu, 1 Oct 2015 17:00:30 +0000 (UTC) Received: (qmail 46333 invoked by uid 500); 1 Oct 2015 17:00:30 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 46225 invoked by uid 500); 1 Oct 2015 17:00:30 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 45993 invoked by uid 99); 1 Oct 2015 17:00:30 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2015 17:00:30 +0000 Date: Thu, 1 Oct 2015 17:00:30 +0000 (UTC) From: "zhihai xu (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: =?utf-8?Q?[jira]_[Updated]_(YARN-4209)_RMS?= =?utf-8?Q?tateStore_FENCED_state_doesn=E2=80=99t_w?= =?utf-8?Q?ork_due_to_updateFencedState_cal?= =?utf-8?Q?led_by_stateMachine.doTransition?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4209?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] zhihai xu updated YARN-4209: ---------------------------- Attachment: YARN-4209.002.patch > RMStateStore FENCED state doesn=E2=80=99t work due to updateFencedState c= alled by stateMachine.doTransition > -------------------------------------------------------------------------= -------------------------- > > Key: YARN-4209 > URL: https://issues.apache.org/jira/browse/YARN-4209 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Affects Versions: 2.7.2 > Reporter: zhihai xu > Assignee: zhihai xu > Priority: Critical > Attachments: YARN-4209.000.patch, YARN-4209.001.patch, YARN-4209.= 002.patch > > > RMStateStore FENCED state doesn=E2=80=99t work due to {{updateFencedState= }} called by {{stateMachine.doTransition}}. The reason is > {{stateMachine.doTransition}} called from {{updateFencedState}} is embedd= ed in {{stateMachine.doTransition}} called from public API(removeRMDelegati= onToken...) or {{ForwardingEventHandler#handle}}. So right after the intern= al state transition from {{updateFencedState}} changes the state to FENCED = state, the external state transition changes the state back to ACTIVE state= . The end result is that RMStateStore is still in ACTIVE state even after {= {notifyStoreOperationFailed}} is called. The only working case for FENCED s= tate is {{notifyStoreOperationFailed}} called from {{ZKRMStateStore#VerifyA= ctiveStatusThread}}. > For example: {{removeRMDelegationToken}} =3D> {{handleStoreEvent}} =3D> e= nter external {{stateMachine.doTransition}} =3D> {{RemoveRMDTTransition}} = =3D> {{notifyStoreOperationFailed}} =3D>{{updateFencedState}}=3D>{{handleSt= oreEvent}}=3D> enter internal {{stateMachine.doTransition}} =3D> exit inter= nal {{stateMachine.doTransition}} change state to FENCED =3D> exit external= {{stateMachine.doTransition}} change state to ACTIVE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)