Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 22 Oct 2015 16:09:27 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12862348.1441698690000.30186.1445530167823@Atlassian.JIRA>
In-Reply-To: <JIRA.12862348.1441698690000@Atlassian.JIRA>
References: <JIRA.12862348.1441698690000@Atlassian.JIRA>
 <JIRA.12862348.1441698690423@arcas>
Subject: [jira] [Commented] (YARN-4129) Refactor the SystemMetricPublisher
 in RM to better support newer events
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969364#comment-14969364 ] 

Hadoop QA commented on YARN-4129:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  16m 45s | Findbugs (version ) appears to be broken on YARN-2928. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 3 new or modified test files. |
| {color:green}+1{color} | javac |   8m  1s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  10m 43s | There were no new javadoc warning messages. |
| {color:red}-1{color} | release audit |   0m 20s | The applied patch generated 1 release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 24s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m 30s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 41s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 44s | The patch built with eclipse:eclipse. |
| {color:red}-1{color} | findbugs |   0m 18s | Post-patch findbugs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager compilation is broken. |
| {color:green}+1{color} | findbugs |   0m 18s | The patch does not introduce any new Findbugs (version ) warnings. |
| {color:red}-1{color} | yarn tests |   0m 18s | Tests failed in hadoop-yarn-server-resourcemanager. |
| | |  39m 52s | |
\\
\\
|| Reason || Tests ||
| Failed build | hadoop-yarn-server-resourcemanager |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12768050/YARN-4129-YARN-2928.004.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / 581a6b6 |
| Release Audit | https://builds.apache.org/job/PreCommit-YARN-Build/9524/artifact/patchprocess/patchReleaseAuditProblems.txt |
| hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/9524/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/9524/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/9524/console |


This message was automatically generated.

> Refactor the SystemMetricPublisher in RM to better support newer events
> -----------------------------------------------------------------------
>
>                 Key: YARN-4129
>                 URL: https://issues.apache.org/jira/browse/YARN-4129
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-4129-YARN-2928.002.patch, YARN-4129-YARN-2928.003.patch, YARN-4129-YARN-2928.004.patch, YARN-4129.YARN-2928.001.patch
>
>
> Currently to add new timeline event/ entity in RM side, one has to add a method in publisher and a method in handler and create a new event class which looks cumbersome and redundant. also further all the events might not be required to be published in V1 & V2. So adopting the approach similar to what was adopted in YARN-3045(NM side)


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)