hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Kalaszi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4263) Capacity scheduler 60%-40% formatting floating point issue
Date Wed, 21 Oct 2015 10:10:27 GMT

    [ https://issues.apache.org/jira/browse/YARN-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966581#comment-14966581
] 

Adrian Kalaszi commented on YARN-4263:
--------------------------------------

- "Could you remove the whitespaces in the test addition? Also, did you check if the tests
fail reliably without the change added along, just to eliminate away any format changes?"
- "Lets switch to using org.apache.hadoop.util.StringUtils.formatPercent method instead of
adding a duplicate inside YARN."
-- Sure, I will do that

- "Am also wondering if we should do a single decimal place instead of two, just to be compatible
with the usual 40.0/60.0/0.0/100.0 outputs."
--I just wanted to fix the bug here, strictly without adding any 'features'. It is a good
idea, however I will do that, if it still fits in this jira.

> Capacity scheduler 60%-40% formatting floating point issue
> ----------------------------------------------------------
>
>                 Key: YARN-4263
>                 URL: https://issues.apache.org/jira/browse/YARN-4263
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 2.7.1
>            Reporter: Adrian Kalaszi
>            Priority: Trivial
>              Labels: easyfix
>         Attachments: YARN-4263.001.patch
>
>
> If capacity scheduler is set with two queues to 60% and 40% capacity, due to a java float
floating representation issue
> {code}
> > hadoop queue -list
> ======================
> Queue Name : default 
> Queue State : running 
> Scheduling Info : Capacity: 40.0, MaximumCapacity: 100.0, CurrentCapacity: 0.0 
> ======================
> Queue Name : large 
> Queue State : running 
> Scheduling Info : Capacity: 60.000004, MaximumCapacity: 100.0, CurrentCapacity: 0.0 
> {code}
> Because 
> {code} System.err.println((0.6f) * 100); {code}
> results in 60.000004.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message