hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4221) Store user in app to flow table
Date Mon, 05 Oct 2015 17:06:26 GMT

    [ https://issues.apache.org/jira/browse/YARN-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943668#comment-14943668
] 

Sangjin Lee commented on YARN-4221:
-----------------------------------

Thanks for turning around and creating this patch quickly, [~varun_saxena]!

I am in agreement with the approach taken in this patch. I'm going to take a closer look once
we commit YARN-3864.

One high level comment: I think we should document the behavior of the REST API with as much
detail as possible. It should be very clear about what params are required and what params
are optional, what type of contents would be returned, and in what order the entities will
be, etc. The javadoc here is as important as the code itself. So for example, we should have
plenty of documentation on where the user id is required and where it is optional.

> Store user in app to flow table
> -------------------------------
>
>                 Key: YARN-4221
>                 URL: https://issues.apache.org/jira/browse/YARN-4221
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-4221-YARN-2928.01.patch
>
>
> We should store user as well in in app to flow table.
> For queries where user is not supplied and flow context can be retrieved from app to
flow table, we should take the user from app to flow table instead of considering UGI as default
user.
> This is as per discussion on YARN-3864



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message