hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering
Date Tue, 06 Oct 2015 18:03:27 GMT

    [ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945475#comment-14945475
] 

Sangjin Lee commented on YARN-4178:
-----------------------------------

The latest patch looks good to me for the most part. I just had one minor point.

(TimelineStorageUtils.java)
- l.169: I might prefer to name this method a little differently. Currently, the right method
will be picked depending on the type of the input argument. However, I see possibility of
making a mistake and accidentally getting an incorrect result. How about differentiating this
strongly, e.g. {{invertInt()}}?


> [storage implementation] app id as string in row keys can cause incorrect ordering
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-4178
>                 URL: https://issues.apache.org/jira/browse/YARN-4178
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-4178-YARN-2928.01.patch, YARN-4178-YARN-2928.02.patch, YARN-4178-YARN-2928.03.patch,
YARN-4178-YARN-2928.04.patch
>
>
> Currently the app id is used in various places as part of row keys. However, currently
they are treated as strings. This will cause a problem with ordering when the id portion of
the app id rolls over to the next digit.
> For example, "app_1234567890_10000" will be considered *earlier* than "app_1234567890_9999".
We should correct this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message