hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4162) Scheduler info in REST, is currently not displaying partition specific queue information similar to UI
Date Fri, 09 Oct 2015 04:19:26 GMT

    [ https://issues.apache.org/jira/browse/YARN-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949871#comment-14949871
] 

Naganarasimha G R commented on YARN-4162:
-----------------------------------------

Hi [~wangda],
Thanks for the review comments and supporting with local testing.
bq. Is it possible to use the same PartitionQueueCapacitiesInfo instead of check if csqinfo.label
== null or not?
well i can avoid the if block but csqinfo.label itself cannot be set to the default Partition
as its also been used as flag to determine to show the leaf queue in the normal way or the
partition way.

bq. Why this isExclusiveNodeLabel check is needed?
isExclusiveNodeLabel is the check we had earlier in CapacitySchedulerInfo.getQueues, basically
to avoid displaying the queues which is not accessible to a given NodeLabelPartition.
{code}
93	    for (CSQueue queue : parentQueue.getChildQueues()) {	92	    for (CSQueue queue : parentQueue.getChildQueues())
{
94	      if (nodeLabel.getIsExclusive()		
95	          && !((AbstractCSQueue) queue).accessibleToPartition(nodeLabel		
96	              .getLabelName())) {		
97	        // Skip displaying the hierarchy for the queues for which the exclusive		
98	        // labels are not accessible		
99	        continue;		
100	      }
{code}
bq. Could you update <DEFAULT_PARTITION> to DEFAULT_PARTITION?
Well shall i update in all places displayed in UI or only in REST ?

For other comments will get it updated in the next patch .


> Scheduler info in REST, is currently not displaying partition specific queue information
similar to UI
> ------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4162
>                 URL: https://issues.apache.org/jira/browse/YARN-4162
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-4162.v1.001.patch, YARN-4162.v2.001.patch, YARN-4162.v2.002.patch,
YARN-4162.v2.003.patch, restAndJsonOutput.zip
>
>
> When Node Labels are enabled then REST Scheduler Information should also provide partition
specific queue information similar to the existing Web UI



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message