hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3216) Max-AM-Resource-Percentage should respect node labels
Date Thu, 22 Oct 2015 06:49:27 GMT

    [ https://issues.apache.org/jira/browse/YARN-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968646#comment-14968646
] 

Wangda Tan commented on YARN-3216:
----------------------------------

Thanks for update, [~sunilg].

Some minor comments:

1) Minor suggestions in LeafQueue#getAMResourceLimitPerPartition:
{code}
    Resource queueCurrentLimit;
    synchronized (queueResourceLimitsInfo) {
      queueCurrentLimit = queueResourceLimitsInfo.getQueueCurrentLimit();
    }
{code}

could be placed within {{if (!nodePartition.equals(RMNodeLabelsManager.NO_LABEL))}} check.

It maybe better to assign a variable to 
{code}
Resources.max(resourceCalculator,
            lastClusterResource, queueCurrentLimit,
            queuePartitionResource)
{code}

Such as, queuePartitionUsableResource, etc.

2) Will tests fail if revert changes of TestNodeLabelContainerAllocation. Same as TestWorkPreservingRMRestartForNodeLabel

3) Tests:
Suggestions:
testAtleastOneAMRunScenarioPerPartition -> testAtleastOneAMRunPerPartition

> Max-AM-Resource-Percentage should respect node labels
> -----------------------------------------------------
>
>                 Key: YARN-3216
>                 URL: https://issues.apache.org/jira/browse/YARN-3216
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>            Priority: Critical
>         Attachments: 0001-YARN-3216.patch, 0002-YARN-3216.patch, 0003-YARN-3216.patch,
0004-YARN-3216.patch, 0005-YARN-3216.patch, 0006-YARN-3216.patch, 0007-YARN-3216.patch, 0008-YARN-3216.patch
>
>
> Currently, max-am-resource-percentage considers default_partition only. When a queue
can access multiple partitions, we should be able to compute max-am-resource-percentage based
on that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message